[system] Add ThemeProvider noSsr to prevent double rendering#44451
Merged
siriwatknp merged 11 commits intomui:masterfrom Nov 26, 2024
Merged
[system] Add ThemeProvider noSsr to prevent double rendering#44451siriwatknp merged 11 commits intomui:masterfrom
noSsr to prevent double rendering#44451siriwatknp merged 11 commits intomui:masterfrom
Conversation
siriwatknp
added
the
scope: system
siriwatknp
changed the title
disableExtraRender to prevent extra rerenderingdisableClientRerender to prevent extra rerendering
…/theme-provider-force
siriwatknp
added
the
type: enhancement
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
github-actions
bot
added
the
PR: out-of-date
siriwatknp
changed the title
disableClientRerender to prevent extra rerenderingnoSsr to prevent double rendering
siriwatknp
changed the title
noSsr to prevent double renderingnoSsr to prevent double rendering
github-actions
bot
removed
the
PR: out-of-date
DiegoAndai
approved these changes
Nov 25, 2024
Comment on lines
+61
to
+62
| * If `true`, ThemeProvider will not rerender and the initial value of `mode` comes from the local storage. | ||
| * For SSR applications, you must ensure that the server render output must match the initial render output on the client. |
Member
There was a problem hiding this comment.
Should we rewrite this prop description?
If true, ThemeProvider will not rerender and the initial value of mode comes from the local storage.I don't understand what this means. Is this the same as https://mui.com/material-ui/react-use-media-query/#api?- must […] must duplication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #43263
Context
The current implementation contains rerendering to make the
modeinitiallyundefinedon the client to prevent any hydration mismatch.However, for apps that does not need this double rendering behavior they could not opt-out. This PR introduces a flag to opt-out this behavior.
The use case for this flag are:
undefined.